Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xenospawners #192

Merged
merged 12 commits into from
Sep 18, 2024
Merged

Xenospawners #192

merged 12 commits into from
Sep 18, 2024

Conversation

fenndragon
Copy link
Contributor

@fenndragon fenndragon commented Sep 17, 2024

Description

added updated sprites for the rouny, as well as added a stomach definition for him to fix an issue where he could not metabolize anything


Changelog

🆑

  • add: Added a stomach to friend
  • tweak: Tweaked the sprites for downed rounys

adding a stomach to friend
adding organs to friend shaped
editing down and dead sprites for rouny
testing a change to toolspeed
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

RSI Diff Bot; head commit 091a230 merging into 5542c7b
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Aliens/Xenos/rouny.rsi

State Old New Status
crit Modified
dead Modified

Edit: diff updated after 091a230

Copy link
Contributor

@ShatteredSwords ShatteredSwords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work as listed. Sprites work correctly. Questions will be commented on the lines of code.

@FoxxoTrystan FoxxoTrystan added the Priority: 3-Low Should be resolved at some point label Sep 17, 2024
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code fine overall but i feel your just doing those PRs to add your own xenopet, theres only changes to him, his has more buffs then normal xenos ect...

Carefull still.

Resources/Prototypes/Floof/body/Organs/Friendstomach.yml Outdated Show resolved Hide resolved
- type: SolutionContainerManager
solutions:
stomach:
maxVol: 500
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

500 is way too much, fix it around 40-100

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I can do that, it was moreso exagurated to see if it would work to fix the issue, On my test server it seems it did. so I'm fine making it like 100

Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait no, changes dedmanded.

adding friendly Xenos to the ghost role component
@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Sep 17, 2024
@fenndragon
Copy link
Contributor Author

Code fine overall but i feel your just doing those PRs to add your own xenopet, theres only changes to him, his has more buffs then normal xenos ect...

Carefull still.

also, the idea of this branch and such is to add friendly Xeno subjects, the specific ones for Friendshaped/patriarch/ect are indeed my own special variety of these friendly xeno ghost roles, but the idea remains the same, the reason why specific values and such have been put on friend in particular is because I'm testing things as I go on just friend before I roll it out to all the other xeno ghost roles.

@Memeji Memeji merged commit 28662f0 into Fansana:master Sep 18, 2024
13 checks passed
Floof-Station-Bot added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Low Should be resolved at some point Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants